Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/pdct 671 add order by for all gets for families and collections to be on last edited #58

Merged
merged 7 commits into from
Dec 7, 2023
Merged

Feature/pdct 671 add order by for all gets for families and collections to be on last edited #58

merged 7 commits into from
Dec 7, 2023

Conversation

katybaulch
Copy link
Contributor

@katybaulch katybaulch commented Dec 7, 2023 •
edited
Loading

Description

Linear ticket PDCT-671.

  • Added sorting by last modified descending on family and collection entities for all() and search() endpoints
  • Document search ordering to come endpoint (which we need to do at a later date)

Type of change

Please select the option(s) below that are most relevant:

  • Bug fix
  • New feature
  • Breaking change

How Has This Been Tested?

Manually.

Reviewer Checklist

  • The PR represents a single feature (small drive-by fixes are also ok)
  • The PR includes tests that are sufficient for the level of risk
  • The code is sufficiently commented, particularly in hard-to-understand areas
  • Any required documentation updates have been made
  • Any TODOs added are captured in future tickets
  • No FIXMEs remain

@katybaulch katybaulch requested a review from diversemix December 7, 2023 17:23
@linear Linear
Copy link

linear bot commented Dec 7, 2023

PDCT-671 Add ORDER BY for all "GET" s for entities to be on last edited.

diversemix
diversemix reviewed Dec 7, 2023
View reviewed changes
app/repository/event.py Outdated Show resolved Hide resolved
@katybaulch katybaulch changed the title Feature/pdct 671 add order by for all get s for entities to be on last edited Feature/pdct 671 add order by for all gets for families and collections to be on last edited Dec 7, 2023
@katybaulch katybaulch merged commit 542e979 into main Dec 7, 2023
2 checks passed
@katybaulch katybaulch deleted the feature/PDCT-671-add-order-by-for-all-get-s-for-entities-to-be-on-last-edited branch December 7, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diversemix diversemix diversemix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@katybaulch @diversemix